RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v23]

[Alan Bateman]

On Fri, 29 Nov 2024 13:26:03 GMT, Volkan Yazıcı <duke at openjdk.org> wrote:

>> test/jdk/java/net/Socket/ConnectFailTest.java line 72:
>> 
>>> 70: 
>>> 71:     /**
>>> 72:      * Verifies socket is closed when {@code unboundSocket.connect()} fails.
>> 
>> Did you mean to say "unboundSocket.connect"? I assume to mean to that it tests that an unbound Socket is closed when connect fails.
>
> The current Javadoc is as follows:
> 
> 
> Verifies socket is closed when {@code unboundSocket.connect()} fails.
> 
> 
> Doesn't this express what you want me to say? How shall I rephrase it?

No big deal, it just looks a bit because "unboundSocket" is not a parameter or field. Leave it if you want.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22160#discussion_r1863599478