RFR: 8343791: Socket.connect API should document whether the socket will be closed when hostname resolution fails or another error occurs [v23]

Volkan Yazıcı duke at openjdk.org
Fri Nov 29 15:31:42 UTC 2024


On Fri, 29 Nov 2024 14:26:19 GMT, Alan Bateman <alanb at openjdk.org> wrote:

>> The current Javadoc is as follows:
>> 
>> 
>> Verifies socket is closed when {@code unboundSocket.connect()} fails.
>> 
>> 
>> Doesn't this express what you want me to say? How shall I rephrase it?
>
> No big deal, it just looks a bit because "unboundSocket" is not a parameter or field. Leave it if you want.

Gotcha. Rephrased Javadocs.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/22160#discussion_r1863688784


More information about the net-dev mailing list