RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v2]
Jaikiran Pai
jpai at openjdk.org
Tue Oct 22 14:22:39 UTC 2024
On Mon, 21 Oct 2024 11:19:08 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> Please find here a fix that improves flow control in the HTTP/2 implementation.
>>
>> The change makes sure that flow control issues are reported to the server as FLOW_CONTROL_ERROR.
>> It also clarify how some system properties that allow to initialize flow control windows are handled, by documenting the full range of valid values (when applicable) and explaining what happens if the property points to a value that is out of range.
>>
>> Bad flow control values in the SETTINGS frame will also cause a FLOW_CONTROL_ERROR to be reported.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>
> Apply suggestions from code review
>
> Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>
src/java.net.http/share/classes/module-info.java line 64:
> 62: * The implementation guarantees that the actual value will be no smaller than the stream
> 63: * window size, which can be configured through the {@code jdk.httpclient.windowsize}
> 64: * system property.
Although these changes to the system property documentation are trivial, I think this would require a CSR, since these are "assertable" changes.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/21567#discussion_r1810825919
More information about the net-dev
mailing list