RFR: 8342075: HttpClient: improve HTTP/2 flow control checks [v2]

[Jaikiran Pai]

On Mon, 21 Oct 2024 11:19:08 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> Please find here a fix that improves flow control in the HTTP/2 implementation.
>> 
>> The change makes sure that flow control issues are reported to the server as FLOW_CONTROL_ERROR.
>> It also clarify how some system properties that allow to initialize flow control windows are handled, by documenting the full range of valid values (when applicable) and explaining what happens if the property points to a value that is out of range.
>> 
>> Bad flow control values in the SETTINGS frame will also cause a FLOW_CONTROL_ERROR to be reported.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Apply suggestions from code review
>   
>   Co-authored-by: Andrey Turbanov <turbanoff at gmail.com>

Overall this looks good to me. The newly added code comments were very helpful.
I haven't paid a very close attention to the tests but have glanced over them and those too look OK to me.

I have added a few minor review comments inline.

-------------

Marked as reviewed by jpai (Reviewer).

PR Review: https://git.openjdk.org/jdk/pull/21567#pullrequestreview-2385391148