RFR: 8349910: Implement HTTP/3 for the HTTP Client API

[Jaikiran Pai]

On Tue, 22 Apr 2025 16:10:19 GMT, Artur Barashev <abarashev at openjdk.org> wrote:

>> Hi,
>> 
>> Please find here a PR for the implementation of JEP [JDK-8291976: HTTP/3 for the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8291976).
>> 
>> The CSR can be viewed at [JDK-8350588: Implement HTTP/3 for the HTTP Client API](https://bugs.openjdk.org/browse/JDK-8350588)
>> 
>> This JEP proposes to enhance the HttpClient implementation to support HTTP/3.
>> It adds a non-exposed / non-exported internal implementation of the QUIC protocol based on DatagramChannel and the SunJSSE SSLContext provider.
>
> src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java line 366:
> 
>> 364:     }
>> 365: 
>> 366:     public String chooseServerAlias(String keyType,
> 
> This method should have default (package-private) access modifier.

Hello Artur, you are right. This is an overisght and we'll fix this as part of the next refresh of this PR.

> src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java line 375:
> 
>> 373:     }
>> 374: 
>> 375:     public String chooseClientAlias(String[] keyTypes, Principal[] issuers,
> 
> Same as above, the method shouldn't be public.

Agreed. We will address this in the next refresh of the PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2055469463
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2055470483