RFR: 8349910: Implement HTTP/3 for the HTTP Client API [v2]

[Jaikiran Pai]

On Wed, 23 Apr 2025 07:54:39 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java line 366:
>> 
>>> 364:     }
>>> 365: 
>>> 366:     public String chooseServerAlias(String keyType,
>> 
>> This method should have default (package-private) access modifier.
>
> Hello Artur, you are right. This is an overisght and we'll fix this as part of the next refresh of this PR.

This is now addressed in the latest update to this PR.

>> src/java.base/share/classes/sun/security/ssl/X509KeyManagerImpl.java line 375:
>> 
>>> 373:     }
>>> 374: 
>>> 375:     public String chooseClientAlias(String[] keyTypes, Principal[] issuers,
>> 
>> Same as above, the method shouldn't be public.
>
> Agreed. We will address this in the next refresh of the PR.

This is now addressed in the latest update to this PR.

>> test/jdk/java/net/httpclient/http3/H3QuicTLSConnection.java line 86:
>> 
>>> 84:     public static void main(String[] args) throws Exception {
>>> 85:         // re-enable 3DES
>>> 86:         Security.setProperty("jdk.tls.disabledAlgorithms", "");
>> 
>> Use `SecurityUtils.removeFromDisabledAlgs` and only remove 3DES from this property.
>
> Thank you for pointing to `SecurityUtils`. I updated this test to use that test library and the test continues to work as expected. We will include this change in the next refresh of the PR.

This too is now addressed in the latest update to this PR.

>> test/jdk/java/net/httpclient/http3/H3QuicTLSConnection.java line 95:
>> 
>>> 93:         //System.setProperty("javax.net.ssl.keyStorePassword", PASSWORD);
>>> 94:         //System.setProperty("javax.net.ssl.trustStore", KEYSTORE);
>>> 95:         //System.setProperty("javax.net.ssl.trustStorePassword", PASSWORD);
>> 
>> Why we don't delete this?
>
> This looks like a leftover. I'll remove this as part of the next refresh.

Addressed in the latest update to this PR.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2059464244
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2059464328
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2059464619
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2059464758