RFR: 8372951: The property jdk.httpclient.quic.maxBidiStreams should be renamed to jdk.internal [v2]
Jaikiran Pai
jpai at openjdk.org
Wed Dec 3 15:07:57 UTC 2025
On Wed, 3 Dec 2025 14:14:10 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:
>> The `jdk.httpclient.quic.maxBidiStreams` is an undocumented system property only used in tests. This property is only useful to control the default HTTP/3 test server implementation. It will never be documented or exposed. It should be clearly labelled as internal.
>> The HTTP/3 client always provide a value of 0 for the `initial_max_streams_bidi` transport parameter, so the default value that the quic stack uses internally to set the parameter if no value is provided is never used on the client side.
>>
>> The `H3StreamLimitReachedTest` can be used to verify the change - it won't pass if the property is not correctly configured in the test.
>>
>> I have also taken this opportunity to add comments to the `H3StreamLimitReachedTest` and the `StreamLimitTest`, to explain the logic of each test.
>>
>> With this I believe that we can also say that this change will fix [JDK-8365794](https://bugs.openjdk.org/browse/JDK-8365794).
>
> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains five additional commits since the last revision:
>
> - review feedback update wrong comment
> - Merge branch 'master' into StreamLimitTest-8372951
> - rename maxBidiStreams property
> - fix CLASS_NAME constant
> - 8365794
Marked as reviewed by jpai (Reviewer).
-------------
PR Review: https://git.openjdk.org/jdk/pull/28611#pullrequestreview-3535508394
More information about the net-dev
mailing list