RFR: 8373537: Migrate "test/jdk/com/sun/net/httpserver/" to null-safe "SimpleSSLContext" methods

Daniel Fuchs dfuchs at openjdk.org
Tue Dec 16 09:15:13 UTC 2025


On Fri, 12 Dec 2025 19:31:15 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

> Migrates `test/jdk/com/sun/net/httpserver/` to null-safe `SimpleSSLContext` methods introduced in [JDK-8372661], which is a prerequisite for this change set.

You could maybe have taken advantage of the dependent PR feature here to avoid showing SimpleSSLContext changes in the PR. OK with what you did though. Just a few minor remarks otherwise LGTM.

test/jdk/com/sun/net/httpserver/simpleserver/HttpsServerAlertTest.java line 72:

> 70:             LOGGER.addHandler(ch);
> 71:         }
> 72:         SSLContext.setDefault(sslContext);

You could move that to a static block after line 62 I guess.

test/jdk/com/sun/net/httpserver/simpleserver/HttpsServerTest.java line 80:

> 78:             LOGGER.addHandler(ch);
> 79:         }
> 80:         SSLContext.setDefault(sslContext);

Same here after line 70

-------------

PR Review: https://git.openjdk.org/jdk/pull/28800#pullrequestreview-3582053355
PR Review Comment: https://git.openjdk.org/jdk/pull/28800#discussion_r2622411050
PR Review Comment: https://git.openjdk.org/jdk/pull/28800#discussion_r2622413589


More information about the net-dev mailing list