RFR: 8373537: Migrate "test/jdk/com/sun/net/httpserver/" to null-safe "SimpleSSLContext" methods [v3]
Volkan Yazici
vyazici at openjdk.org
Thu Dec 18 13:55:30 UTC 2025
On Mon, 15 Dec 2025 09:55:09 GMT, Mikhail Yankelevich <myankelevich at openjdk.org> wrote:
>> Volkan Yazici has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains six commits:
>>
>> - Merge remote-tracking branch 'upstream/master' into simpleSslHs
>> - Move `SSLContext::setDefault` to static blocks
>> - Restore `test/jdk/com/sun/net/httpserver/` changes
>> - Make sure `get()` returns the same instance
>> - Reverted all changes and only kept `SimpleSSLContext` enhancements
>> - Overhaul `SimpleSSLContext` and its usages
>
> test/jdk/com/sun/net/httpserver/HttpsParametersClientAuthTest.java line 172:
>
>> 170: // by the server
>> 171: final SSLContext serverSSLCtx = new SimpleSSLContext().get();
>> 172: assertNotNull(serverSSLCtx, "could not create SSLContext");
>
> Minor: Do you think this might still happen? What do you think about adding this as a part of the first run test in case the initialisation fails? Just for debugging convenience
I will try adding a test that ensures `SimpleSSLContext` factory methods don't return null in [JDK-8373538].
[JDK-8373538]: https://bugs.openjdk.org/browse/JDK-8373538
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/28800#discussion_r2631190873
More information about the net-dev
mailing list