RFR: 8373796: Refactor java/net/httpclient/ThrowingPublishers*.java tests to use JUnit5 [v3]

Daniel Fuchs dfuchs at openjdk.org
Wed Dec 17 11:11:23 UTC 2025


> These test used to use the testng `IContextTest` API to stop tests after the first failure.
> @sormuras suggested an even more elegant way to do that with JUnit.
> Usage of IContextTest has been replaced with a `TestWatcher` that records the first failure and uses `Assumptions` to prevent further test execution. 
> 
> The rest of the changes were (almost) mechanical.

Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:

 - Merge branch 'master' into JUnit-ThrowingPublishers-8373796
 - Minor cleanup
 - 8373796: Refactor java/net/httpclient/ThrowingPublishers*.java tests to use JUnit5

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28846/files
  - new: https://git.openjdk.org/jdk/pull/28846/files/2c17b02c..543d2158

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28846&range=02
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28846&range=01-02

  Stats: 5494 lines in 231 files changed: 3750 ins; 458 del; 1286 mod
  Patch: https://git.openjdk.org/jdk/pull/28846.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28846/head:pull/28846

PR: https://git.openjdk.org/jdk/pull/28846


More information about the net-dev mailing list