RFR: 8373796: Refactor java/net/httpclient/ThrowingPublishers*.java tests to use JUnit5 [v3]

Jaikiran Pai jpai at openjdk.org
Thu Dec 18 09:23:44 UTC 2025


On Wed, 17 Dec 2025 11:11:23 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> These test used to use the testng `IContextTest` API to stop tests after the first failure.
>> @sormuras suggested an even more elegant way to do that with JUnit.
>> Usage of IContextTest has been replaced with a `TestWatcher` that records the first failure and uses `Assumptions` to prevent further test execution. 
>> 
>> The rest of the changes were (almost) mechanical.
>
> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains three additional commits since the last revision:
> 
>  - Merge branch 'master' into JUnit-ThrowingPublishers-8373796
>  - Minor cleanup
>  - 8373796: Refactor java/net/httpclient/ThrowingPublishers*.java tests to use JUnit5

Marked as reviewed by jpai (Reviewer).

-------------

PR Review: https://git.openjdk.org/jdk/pull/28846#pullrequestreview-3591644672


More information about the net-dev mailing list