RFR: 8349662: SSLTube SSLSubscriptionWrapper has potential races when switching subscriptions [v2]

Daniel Fuchs dfuchs at openjdk.org
Tue Feb 11 10:06:11 UTC 2025


On Tue, 11 Feb 2025 09:58:32 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review feedback
>
> test/jdk/java/net/httpclient/DigestEchoClient.java line 411:
> 
>> 409:                 BodyPublisher reqBody = BodyPublishers.ofString(body);
>> 410:                 URI baseReq = URI.create(uri + "?iteration=" + i + ",async=" + async
>> 411:                         + ",addHeaders=" + addHeaders + ",preemptive=" + preemptive
> 
> Should this (and the other places where we are updating the request URI) use `&` instead of `,`, for request query parameter delimiting or is this just changed for better logging (on the server side)?

This is just a change so that we can better follow out what belong to which request in the logs (whether client & server). The query is not used/parsed anywhere - it's just there for better diagnosis when the test fails.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23515#discussion_r1950555948


More information about the net-dev mailing list