RFR: 8349662: SSLTube SSLSubscriptionWrapper has potential races when switching subscriptions [v2]

[Daniel Fuchs]

On Tue, 11 Feb 2025 10:00:26 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Review feedback
>
> test/jdk/java/net/httpclient/DigestEchoClient.java line 531:
> 
>> 529:             if (error != null) {
>> 530:                 if (failed != null) error.addSuppressed(failed);
>> 531:                 throw error;
> 
> Do you think an additional `error != failed` check would be needed here, before calling `addSuppressed()` or is that not a concern here?

`error` is a brand new AsssertionError created by the tracker. It simply can't be the same exception as `failed`.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/23515#discussion_r1950565614