RFR: 8342807: Update links in java.base to use https://
Magnus Ihse Bursie
ihse at openjdk.org
Fri Jan 10 16:47:48 UTC 2025
On Tue, 22 Oct 2024 19:29:43 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
>> FWIW: I don't believe a change to a link in a comment in an internal class requires a CSR.
>> For PortConfig.java - it would be good to have someone involved in the AIX port comment on the proposed changes.
>> Removing the obsolete link altogether is also a possibility.
>
>> For PortConfig.java - it would be good to have someone involved in the AIX port comment on the proposed changes. Removing the obsolete link altogether is also a possibility.
>
> The context for the link in PortConfig.java is:
>
>
> // The ephemeral port is OS version dependent on AIX:
> // http://publib.boulder.ibm.com/infocenter/aix/v7r1/topic/com.ibm.aix.rsct315.admin/bl503_ephport.htm
> // However, on AIX 5.3 / 6.1 / 7.1 we always see the
> // settings below by using:
> // /usr/sbin/no -a | fgrep ephemeral
> defaultLower = 32768;
> defaultUpper = 65535;
>
>
> So while the FAQ link I changed this to confirms the port numbers here, it probably makes the comment "The ephemeral port is OS version dependent on AIX" somewhat stale. Seems the original linked document somehow contradicted the observed settings? So if we use my suggested FAQ link, perhaps it is better to remove the surrounding comment altogether, as it seems stale.
>
> For `ProcessImpl_md.c`, the obsolete link was to a request for clarification to what I think may be an early version of some POSIX standard. If I'm right, the current version is https://www.iso.org/standard/50516.html, which is not publicly available (requires paid access).
>
> But yes, would be nice if some AIX people could have a look at this.
@eirbjo This seemed like a valuable and worthwhile contribution, and I think it is a bit sad to see it closed due to inactivity. Was it the lack of volunteering reviewers that made you let it go?
-------------
PR Comment: https://git.openjdk.org/jdk/pull/21633#issuecomment-2583231907
More information about the net-dev
mailing list