RFR: 8342807: Update links in java.base to use https://

[Eirik Bjørsnøs]

On Tue, 22 Oct 2024 19:29:43 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:

>> FWIW: I don't believe a change to a link in a comment in an internal class requires a CSR.
>> For PortConfig.java - it would be good to have someone involved in the AIX port comment on the proposed changes. 
>> Removing the obsolete link altogether is also a possibility.
>
>> For PortConfig.java - it would be good to have someone involved in the AIX port comment on the proposed changes. Removing the obsolete link altogether is also a possibility.
> 
> The context for the link in PortConfig.java is: 
> 
> 
> // The ephemeral port is OS version dependent on AIX:
> // http://publib.boulder.ibm.com/infocenter/aix/v7r1/topic/com.ibm.aix.rsct315.admin/bl503_ephport.htm
> // However, on AIX 5.3 / 6.1 / 7.1 we always see the
> // settings below by using:
> // /usr/sbin/no -a | fgrep ephemeral
> defaultLower = 32768;
> defaultUpper = 65535;
> 
> 
> So while the FAQ link I changed this to confirms the port numbers here, it probably makes the comment "The ephemeral port is OS version dependent on AIX" somewhat stale. Seems the original linked document somehow contradicted the observed settings? So if we use my suggested FAQ link, perhaps it is better to remove the surrounding comment altogether, as it seems stale. 
> 
> For `ProcessImpl_md.c`, the obsolete link was to a request for clarification to what I think may be an early version of some POSIX standard. If I'm right, the current version is https://www.iso.org/standard/50516.html, which is not publicly available (requires paid access).
> 
> But yes, would be nice if some AIX people could have a look at this.

> @eirbjo This seemed like a valuable and worthwhile contribution, and I think it is a bit sad to see it closed due to inactivity. Was it the lack of volunteering reviewers that made you let it go?

Thanks for looking at this Magnus, I agree cleaning this up would be good.

Although most of the link updates are trivial and safe, I think we just got stuck on the two links which were not completely clear how to update:

`PortConfig.java`:

This file  includes a link to some legacy IBM documentation on ephemral ports on AIX which is no longer accessible. I found an IBM FAQ page which mentions ephemral port ranges and suggest this as the replacement. @dfuch suggested:"it would be good to have someone involved in the AIX port comment on the proposed changes", however this never happened. I'm not sure who to ask.

We can make progress here by getting someone with AIX experience to review, or we can simply remove the link. I personally think the replacement link I found is "good enough", although I've never actually seen the current link contents.

`ProcessImpl_md.c`:

This file includes a link to `www.pasc.org` for an unofficial interpretation of an early POSIX standard. This document now requires authentication. The PR currently links to a Wayback page, but maybe we should should rather remove this link altogether since it was always considered "unofficial" and the interpretation in question has long been baked into the standard.

So based on the above, my  "call to action" for this PR in the current state is:

a) Find out who we can invite with AIX experience to look at the updates to `PortConfig.java`
b) If that fails, I'll remove the link and ask for a review of that
c) I would like feedback on the proposal to remove the link to the www.pasc.org "unofficial" interpretation document in `ProcessImpl_mc.c`

Thanks!

-------------

PR Comment: https://git.openjdk.org/jdk/pull/21633#issuecomment-2599018576