RFR: 8358688: HttpClient: Simplify file streaming in RequestPublishers.FilePublisher
Jaikiran Pai
jpai at openjdk.org
Thu Jun 5 14:09:51 UTC 2025
On Thu, 5 Jun 2025 13:30:10 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
> Simplifies content streaming for `HttpRequest.BodyPublishers::ofFile(Path)`, which delegates to `RequestPublishers.FilePublisher::create(Path)`. This effectively replaces all usages of `FileInputStream::new` in `HttpClient` with `Files::newInputStream(Path)`. See the JBS ticket description for the full story.
>
> Also removing certain test files which were rendered redundant after `SecurityManager` removal. We do this in this PR, since tests were added due to touched lines.
>
> `tier1,2` results on b5f3c8dc6f4 are attached to the ticket.
While at it, I think we should also introduce a regression test which does a `BodyPublishers.ofFile(Path)` against a `Path` provided by a ZIP filesystem or some such filesystem which was the cause for failures reported in https://bugs.openjdk.org/browse/JDK-8235459.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25662#issuecomment-2944592755
More information about the net-dev
mailing list