RFR: 8358688: HttpClient: Simplify file streaming in RequestPublishers.FilePublisher
Daniel Fuchs
dfuchs at openjdk.org
Thu Jun 5 15:26:54 UTC 2025
On Thu, 5 Jun 2025 13:30:10 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
> Simplifies content streaming for `HttpRequest.BodyPublishers::ofFile(Path)`, which delegates to `RequestPublishers.FilePublisher::create(Path)`. This effectively replaces all usages of `FileInputStream::new` in `HttpClient` with `Files::newInputStream(Path)`. See the JBS ticket description for the full story.
>
> Also removing certain test files which were rendered redundant after `SecurityManager` removal. We do this in this PR, since tests were added due to touched lines.
>
> `tier1,2` results on b5f3c8dc6f4 are attached to the ticket.
Yes on both counts. Note that the removed tests where also using ZipFileSystem. It would be better to remove them with another PR, after this change is integrated, and only if we can say with certainty that whatever they test is already covered by other tests.
-------------
PR Comment: https://git.openjdk.org/jdk/pull/25662#issuecomment-2944977728
More information about the net-dev
mailing list