RFR: 8340182: Java HttpClient does not follow default retry limit of 3 retries [v3]

[p-nima]

On Fri, 30 May 2025 14:42:11 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> p-nima has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update summary
>
> test/jdk/java/net/httpclient/HttpClientRetryLimitTest.java line 64:
> 
>> 62:             "jdk.httpclient.auth.retrylimit", DEFAULT_RETRY_LIMIT);
>> 63: 
>> 64:     static Stream<HttpClient.Version> args() {
> 
> I think we should also test against with SSL and without SSL cases. See `HttpResponseLimitingTest.ServerClientPair` for inspiration.

We now test it with both the scenarios - 2d0325649e4d0f67e25aa30ba36c1c2555bc59b9

> test/jdk/java/net/httpclient/HttpClientRetryLimitTest.java line 88:
> 
>> 86:             try (
>> 87:                 HttpClient client = HttpClient.newBuilder()
>> 88:                         .authenticator(new Authenticator() {
> 
> To ensure the client will fire the request using the protocol version of our preference, could you also pass `version` to the client builder too, please?

As we now set the version on the request, so we no longer need to set it on the client - 2d0325649e4d0f67e25aa30ba36c1c2555bc59b9

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25490#discussion_r2132392565
PR Review Comment: https://git.openjdk.org/jdk/pull/25490#discussion_r2132394794