RFR: 8340182: Java HttpClient does not follow default retry limit of 3 retries [v3]

[p-nima]

On Fri, 30 May 2025 09:08:46 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> p-nima has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   update summary
>
> test/jdk/java/net/httpclient/HttpClientRetryLimitTest.java line 73:
> 
>> 71:     @ParameterizedTest
>> 72:     @MethodSource("args")
>> 73:     public void testDefaultSystemProperty(HttpClient.Version version) throws Exception {
> 
> I see you made the class package-private in 18bac9f. You could have additionally made the method package-private too.

I have changed it to default - Based on the junit [documentation](https://junit.org/junit5/docs/5.11.0/api/org.junit.jupiter.params/org/junit/jupiter/params/ParameterizedTest.html) we should not mark such methods as private or static


> @ParameterizedTest is used to signal that the annotated method is a parameterized test method.
> Such methods must not be private or static.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25490#discussion_r2132462294