Suggestion needed to port the fix to JDK17 and JDK11S
Shruthi .
Shruthi.Shruthi1 at ibm.com
Mon Jun 16 05:53:46 UTC 2025
Hi Alan,
I ran the tests under java/nio and java/net against the JDK 17 build with the preClose re-order change to check for any regressions, and all tests passed successfully.
Three patches need to be ported to implement this fix in JDK 17 and to keep the source code aligned with the OpenJDK headstream.
* 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl (https://github.com/openjdk/jdk/pull/10434)
* 8351458: (ch) Move preClose to UnixDispatcher (https://github.com/openjdk/jdk/pull/23956)
* 8317801: java/net/Socket/asyncClose/Race.java fails intermittently (aix) (https://bugs.openjdk.org/secure/attachment/113740/pending_signals.patch)
I have raised a backport PR in JDK17 for 8294399: (ch) Refactor some methods out of sun.nio.ch.UnixFileDispatcherImpl
https://github.com/openjdk/jdk17u-dev/pull/3631 - I have tagged you here. Can you please review
I have raised the OpenJDK headstream PR for 8317801: java/net/Socket/asyncClose/Race.java fails intermittently (aix)
https://github.com/openjdk/jdk/pull/25817 - I have tagged you here. Can you please review
Will proceed with the rest of the patches accordingly.
Thanks
Shruthi
________________________________
From: Alan Bateman <alan.bateman at oracle.com>
Sent: Sunday, June 8, 2025 10:52 PM
To: Shruthi . <Shruthi.Shruthi1 at ibm.com>; net-dev at openjdk.org <net-dev at openjdk.org>
Cc: Syed Moinudeen <smoinud1 at in.ibm.com>; SREENIVAS MAKINEEDI <sreeni at us.ibm.com>
Subject: [EXTERNAL] Re: Suggestion needed to port the fix to JDK17 and JDK11S
On 31/05/2025 20: 12, Shruthi . wrote: Hi Alan, I wanted to follow up on the update I shared earlier I’ve successfully backported the preClose re-order changes to JDK 17 and ran the Race. java test case 500 times. It passed consistently without
On 31/05/2025 20:12, Shruthi . wrote:
Hi Alan,
I wanted to follow up on the update I shared earlier
I’ve successfully backported the preClose re-order changes to JDK 17 and ran the Race.java test case 500 times. It passed consistently without any failures. For validation, I also ran the test without the patch, and it failed on the first iteration. I ran the tests under java/nio to see if there is any regression and all the testcases are passing.
Currently, we are running the tests under java/net.
*
Do you recommend running any additional test groups?
*
Also, can we proceed with porting the preClose re-order fix to headstream?
Please let me know your thoughts.
Good to hear that the preClose changes helped. I think the next step is to create a PR for JDK main line.
-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.openjdk.org/pipermail/net-dev/attachments/20250616/11ec9050/attachment-0001.htm>
More information about the net-dev
mailing list