RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v2]
Jaikiran Pai
jpai at openjdk.org
Wed Jun 25 08:54:46 UTC 2025
On Fri, 25 Apr 2025 19:13:14 GMT, Artur Barashev <abarashev at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 409 commits:
>>
>> - merge latest changes from master branch
>> - http3: add missing <p> separator to Http3DiscoveryMode.ALT_SVC API documentation
>> - http3: improve documentation for Http3DiscoveryMode.ALT_SVC
>> - http3: Use AlgorithmConstraints and OCSP responses when validating server certificate during QUIC TLS handshake
>> - http3: Artur's review - use SecurityUtils.removeFromDisabledTlsAlgs() in test
>> - http3: minor improvement to log message
>> - http3: Artur's review - remove commented out code from test
>> - http3: Artur's review - make methods package private
>> - http3: qpack - allow 0 capacity when max capacity is 0
>> - Remove flow control from stream limit comments
>> - ... and 399 more: https://git.openjdk.org/jdk/compare/1ec64811...4da61bbe
>
> src/java.base/share/classes/sun/security/ssl/SSLAlgorithmConstraints.java line 172:
>
>> 170: userSpecifiedConstraints = engine.getSSLParameters()
>> 171: .getAlgorithmConstraints();
>> 172: }
>
> Duplicate code block here and in the 2nd `forQUIC` method. We should move it to a private `getUserSpecifiedConstraints` method, like in SSLEngine and SSLSocket cases.
@dfuch this can be resolved. We followed Artur's suggestion and used a private method for this common code. It's done in commit e11998ddce124044d08c95f2c1d03f61dc20f3ed of this PR.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2166182635
More information about the net-dev
mailing list