RFR: 8349910: Implement JEP 517: HTTP/3 for the HTTP Client API [v2]
Daniel Jeliński
djelinski at openjdk.org
Thu Jun 26 18:02:47 UTC 2025
On Fri, 25 Apr 2025 19:42:34 GMT, Artur Barashev <abarashev at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The pull request now contains 409 commits:
>>
>> - merge latest changes from master branch
>> - http3: add missing <p> separator to Http3DiscoveryMode.ALT_SVC API documentation
>> - http3: improve documentation for Http3DiscoveryMode.ALT_SVC
>> - http3: Use AlgorithmConstraints and OCSP responses when validating server certificate during QUIC TLS handshake
>> - http3: Artur's review - use SecurityUtils.removeFromDisabledTlsAlgs() in test
>> - http3: minor improvement to log message
>> - http3: Artur's review - remove commented out code from test
>> - http3: Artur's review - make methods package private
>> - http3: qpack - allow 0 capacity when max capacity is 0
>> - Remove flow control from stream limit comments
>> - ... and 399 more: https://git.openjdk.org/jdk/compare/1ec64811...4da61bbe
>
> src/java.base/share/classes/sun/security/ssl/SSLConfiguration.java line 532:
>
>> 530: }
>> 531:
>> 532: public boolean isQuic() {
>
> This method never called.
Removed in 9f7f9e190b124d569eae8bf1df5e6c076ad00a06
> src/java.base/share/classes/sun/security/ssl/X509TrustManagerImpl.java line 275:
>
>> 273: final X509Certificate[] trustedChain = v.validate(chain, null,
>> 274: responseList, constraints, authType);
>> 275: if (sslParameters != null && handshakeSession != null) {
>
> Looks like this `if` block is not needed: `sslParameters != null` condition is always `true`, and we should throw an exception in the beginning of the method if session is null.
Moved earlier in 10e3e3508415b901fe0008da4edb5c4f1e8eb85d
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2169589570
PR Review Comment: https://git.openjdk.org/jdk/pull/24751#discussion_r2169588546
More information about the net-dev
mailing list