RFR: 8351347: HttpClient Improve logging of response headers [v2]

[Volkan Yazici]

On Wed, 14 May 2025 09:31:07 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Includes request method, request URI, response status code, and HTTP/2 stream ID while logging response headers in the HTTP Client.
>> 
>> ### Demonstration
>> 
>> Snippets from running JTreg against `test/jdk/java/net/httpclient/HeadTest.java`:
>> 
>> **Before:**
>> 
>> INFO: HEADERS: REQUEST HEADERS:
>> HEAD /transfer/ HTTP/1.1
>> Content-Length: 0
>> Host: 127.0.0.1:43647
>> ...
>> INFO: HEADERS: RESPONSE HEADERS:
>>     connection: Upgrade
>>     upgrade: h2c
>> ...
>> INFO: HEADERS: RESPONSE HEADERS:
>>     :status: 304
>>     content-length: 300
>> ...
>> INFO: HEADERS: HEADERS FRAME (streamid=1):
>>     :authority: 127.0.0.1:50611
>>     :method: GET
>>     :path: /
>> 
>> 
>> **After:** 
>> 
>> INFO: HEADERS: REQUEST HEADERS:
>>   HEAD /transfer/ HTTP/1.1
>>     Content-Length: 0
>>     Host: 127.0.0.1:43647
>> ...
>> INFO: HEADERS: RESPONSE HEADERS:
>>   GET http://127.0.0.1:48497/ 101
>>     connection: Upgrade
>>     upgrade: h2c
>> ...
>> INFO: HEADERS: RESPONSE HEADERS (streamid=1):
>>   GET http://127.0.0.1:48497/ 304
>>     :status: 304
>>     content-length: 300
>> ...
>> INFO: HEADERS: HEADERS FRAME (streamid=1):
>>   GET https://127.0.0.1:50611/
>>     :authority: 127.0.0.1:50611
>>     :method: GET
>>     :path: /
>
> Volkan Yazici has updated the pull request incrementally with three additional commits since the last revision:
> 
>  - Match header logging in `Http1Request` with others
>  - Shorten code
>  - Improve header logging in more places

src/java.net.http/share/classes/jdk/internal/net/http/Http1Request.java line 93:

> 91:                     int protocolFieldPrefixIndex = line.lastIndexOf(' ');
> 92:                     assert protocolFieldPrefixIndex > 0;
> 93:                     sb.append("  ").append(line, 0, protocolFieldPrefixIndex).append('\n');

Suggestion:

                    sb.append("  ").append(line).append('\n');

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25201#discussion_r2090941543