RFR: 8357268: Use JavaNioAccess.getBufferAddress rather than DirectBuffer.address() [v7]
Per Minborg
pminborg at openjdk.org
Mon May 26 12:50:54 UTC 2025
On Mon, 26 May 2025 07:51:32 GMT, Alan Bateman <alanb at openjdk.org> wrote:
>> Per Minborg has updated the pull request incrementally with one additional commit since the last revision:
>>
>> Fix copyright year
>
> src/java.base/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java line 459:
>
>> 457:
>> 458: boolean pending = false;
>> 459: IOUtil.acquireScope(buf, true);
>
> Would you mind checking the use of acquireScope in WindowsAsynchronousSocketChannelImpl? From a quick look I'm wondering why it doesn't call the 2-arg acquireScope with async=true.
WASCI is using acquireScopes (plural) and this delegates to aquireScope(.., async=true). So, looks good.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/25324#discussion_r2107273542
More information about the net-dev
mailing list