RFR: 8357268: Use JavaNioAccess.getBufferAddress rather than DirectBuffer.address() [v7]

Alan Bateman alanb at openjdk.org
Mon May 26 15:53:57 UTC 2025


On Mon, 26 May 2025 12:47:55 GMT, Per Minborg <pminborg at openjdk.org> wrote:

>> src/java.base/windows/classes/sun/nio/ch/WindowsAsynchronousFileChannelImpl.java line 459:
>> 
>>> 457: 
>>> 458:             boolean pending = false;
>>> 459:             IOUtil.acquireScope(buf, true);
>> 
>> Would you mind checking the use of acquireScope in WindowsAsynchronousSocketChannelImpl? From a quick look I'm wondering why it doesn't call the 2-arg acquireScope with async=true.
>
> WASCI is using acquireScopes (plural) and this delegates to aquireScope(.., async=true). So, looks good.

Good, thanks for checking.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/25324#discussion_r2107592606


More information about the net-dev mailing list