RFR: 8371722: java/net/httpclient/BufferSizePropertyClampTest.java should use Locale.ROOT [v2]

Volkan Yazici vyazici at openjdk.org
Thu Nov 13 06:15:03 UTC 2025


On Wed, 12 Nov 2025 18:03:33 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> The test verifies that the expected message is logged by the jdk.httpclient.HttpClient logger. However it fails when run in e.g. Polish Locale because it expects 16,384 and finds 16 384 (with a non breaking space).
>> 
>> The proposed change makes sure we use Locale.ROOT to format the message.
>
> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
> 
>   Fix the fix

test/jdk/java/net/httpclient/BufferSizePropertyClampTest.java line 73:

> 71: 
> 72:     private static final String EXPECTED_MSG =
> 73:             "ERROR: Property value for jdk.httpclient.bufsize={0} not in [1..16,384]: using default=16,384";

Doesn't this have an assumption on the formatting of 1 and 16384, and hence, suffers from the same short-coming this fix is aiming to solve? That is, the original `Utils::getIntegerNetProperty` message is as follows:


"Property value for {0}={1} not in [{2}..{3}]: using default={4}"


Shouldn't we be using this message verbatim instead?

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28270#discussion_r2521731243


More information about the net-dev mailing list