RFR: 8371722: java/net/httpclient/BufferSizePropertyClampTest.java should use Locale.ROOT [v2]

[Daniel Fuchs]

On Thu, 13 Nov 2025 06:12:50 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:

>> Daniel Fuchs has updated the pull request incrementally with one additional commit since the last revision:
>> 
>>   Fix the fix
>
> test/jdk/java/net/httpclient/BufferSizePropertyClampTest.java line 73:
> 
>> 71: 
>> 72:     private static final String EXPECTED_MSG =
>> 73:             "ERROR: Property value for jdk.httpclient.bufsize={0} not in [1..16,384]: using default=16,384";
> 
> Doesn't this have an assumption on the formatting of 1 and 16384, and hence, suffers from the same short-coming this fix is aiming to solve? That is, the original `Utils::getIntegerNetProperty` message is as follows:
> 
> 
> "Property value for {0}={1} not in [{2}..{3}]: using default={4}"
> 
> 
> Shouldn't we be using this message verbatim instead?

Yes and no. We're now using Locale.ROOT to do the formating so we know how it will be formatted (and can make the assumption).

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28270#discussion_r2522901042