RFR: 8326498: java.net.http.HttpClient connection leak using http/2 [v13]

Jaikiran Pai jpai at openjdk.org
Mon Nov 24 11:26:41 UTC 2025


> Can I please get a review for this fix which addresses a connection leak in HttpClient when dealing with HTTP/2 requests?
> 
> I have added a comment in https://bugs.openjdk.org/browse/JDK-8326498 which explains what the issue is. The fix here addresses the issue by cleaning up the `Http2Connection` closing logic and centralizing it to a connection terminator. The terminator then ensures that the right resources are closed (including the underlying SocketChannel) when the termination happens.
> 
> A new jtreg test has been introduced which reproduces the issue and verifies the fix.

Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:

  test-only change - expect HttpClientImpl to be the underlying HttpClient implementation

-------------

Changes:
  - all: https://git.openjdk.org/jdk/pull/28233/files
  - new: https://git.openjdk.org/jdk/pull/28233/files/b7389dde..3885a5df

Webrevs:
 - full: https://webrevs.openjdk.org/?repo=jdk&pr=28233&range=12
 - incr: https://webrevs.openjdk.org/?repo=jdk&pr=28233&range=11-12

  Stats: 4 lines in 1 file changed: 1 ins; 2 del; 1 mod
  Patch: https://git.openjdk.org/jdk/pull/28233.diff
  Fetch: git fetch https://git.openjdk.org/jdk.git pull/28233/head:pull/28233

PR: https://git.openjdk.org/jdk/pull/28233


More information about the net-dev mailing list