RFR: 8326498: java.net.http.HttpClient connection leak using http/2 [v13]

[Daniel Jeliński]

On Mon, 24 Nov 2025 11:26:41 GMT, Jaikiran Pai <jpai at openjdk.org> wrote:

>> Can I please get a review for this fix which addresses a connection leak in HttpClient when dealing with HTTP/2 requests?
>> 
>> I have added a comment in https://bugs.openjdk.org/browse/JDK-8326498 which explains what the issue is. The fix here addresses the issue by cleaning up the `Http2Connection` closing logic and centralizing it to a connection terminator. The terminator then ensures that the right resources are closed (including the underlying SocketChannel) when the termination happens.
>> 
>> A new jtreg test has been introduced which reproduces the issue and verifies the fix.
>
> Jaikiran Pai has updated the pull request incrementally with one additional commit since the last revision:
> 
>   test-only change - expect HttpClientImpl to be the underlying HttpClient implementation

test/jdk/java/net/httpclient/http2/BurstyRequestsTest.java line 125:

> 123:                      .build()) {
> 124:             // our test needs to peek into the internal field of jdk.internal.net.http.HttpClientImpl,
> 125:             // so we skip the test if the HttpClient isn't of the expected type

This comment is outdated now.

-------------

PR Review Comment: https://git.openjdk.org/jdk/pull/28233#discussion_r2555916283