RFR: 8378276: Refactor test/jdk/java/net/httpclient/quic/ TestNG tests to JUnit [v2]

Volkan Yazici vyazici at openjdk.org
Fri Feb 20 14:50:51 UTC 2026


On Fri, 20 Feb 2026 11:08:57 GMT, Daniel Fuchs <dfuchs at openjdk.org> wrote:

>> TestNG tests located under test/jdk/java/net/httpclient/quic/ are refactored to use JUnit.
>>  Mostly mechanical - a couple of `assertEquals` calls had to be turned into `assertArrayEquals`.
>
> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
> 
>  - Merge branch 'master' into ITestContext-quic-8378276
>  - 8378276: Refactor test/jdk/java/net/httpclient/quic/ TestNG tests to JUnit

Marked as reviewed by vyazici (Reviewer).

test/jdk/java/net/httpclient/quic/tls/PacketEncryptionTest.java line 321:

> 319:     @Test
> 320:     public void testVerifyBadRetry() throws NoSuchAlgorithmException, AEADBadTagException, QuicTransportException {
> 321:         Assertions.assertThrows(AEADBadTagException.class, () -> {

Doesn't this make `throws NoSuchAlgorithmException, AEADBadTagException, QuicTransportException` redundant?

Note that this applies to several other `assertThrows` refactorings in this change set.

-------------

PR Review: https://git.openjdk.org/jdk/pull/29841#pullrequestreview-3832425879
PR Review Comment: https://git.openjdk.org/jdk/pull/29841#discussion_r2833571545


More information about the net-dev mailing list