RFR: 8378276: Refactor test/jdk/java/net/httpclient/quic/ TestNG tests to JUnit [v2]
Daniel Fuchs
dfuchs at openjdk.org
Fri Feb 20 17:30:54 UTC 2026
On Fri, 20 Feb 2026 14:46:09 GMT, Volkan Yazici <vyazici at openjdk.org> wrote:
>> Daniel Fuchs has updated the pull request with a new target base due to a merge or a rebase. The incremental webrev excludes the unrelated changes brought in by the merge/rebase. The pull request contains two additional commits since the last revision:
>>
>> - Merge branch 'master' into ITestContext-quic-8378276
>> - 8378276: Refactor test/jdk/java/net/httpclient/quic/ TestNG tests to JUnit
>
> test/jdk/java/net/httpclient/quic/tls/PacketEncryptionTest.java line 321:
>
>> 319: @Test
>> 320: public void testVerifyBadRetry() throws NoSuchAlgorithmException, AEADBadTagException, QuicTransportException {
>> 321: Assertions.assertThrows(AEADBadTagException.class, () -> {
>
> Doesn't this make `throws NoSuchAlgorithmException, AEADBadTagException, QuicTransportException` redundant?
>
> Note that this applies to several other `assertThrows` refactorings in this change set.
Good catch! Fixed.
-------------
PR Review Comment: https://git.openjdk.org/jdk/pull/29841#discussion_r2833679615
More information about the net-dev
mailing list