RFR: 8378398: Modernize test/jdk/java/net/URLClassLoader/HttpTest.java [v5]
Eirik Bjørsnøs
eirbjo at openjdk.org
Tue Feb 24 14:58:25 UTC 2026
> Please review this PR which modernizes `test/jdk/java/net/URLClassLoader/HttpTest.java`, a test verifying HTTP requests made by a URLClassLoader with HTTP search paths.
>
> The test is updated to replace a custom `HttpServer` class with one using `com.sun.net.httpserver`. Instead of simply counting GET and HEAD requests, the test now captures each request's method and URI in a log, which allows more precise asserts on the expected request patterns.
>
> The test is updated to use JUnit 5.
>
> For good measure, some negative test methods are added, verifying expected HTTP requests when one of the HTTP paths returns a 404 response.
>
> Test-only enhancement, `noreg-self`
Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:
Add tests for URLClassLoader::getResource following a redirect and another test where the redirect location returns 404 Not Found.
-------------
Changes:
- all: https://git.openjdk.org/jdk/pull/29864/files
- new: https://git.openjdk.org/jdk/pull/29864/files/b6a47357..22048aea
Webrevs:
- full: https://webrevs.openjdk.org/?repo=jdk&pr=29864&range=04
- incr: https://webrevs.openjdk.org/?repo=jdk&pr=29864&range=03-04
Stats: 58 lines in 1 file changed: 50 ins; 5 del; 3 mod
Patch: https://git.openjdk.org/jdk/pull/29864.diff
Fetch: git fetch https://git.openjdk.org/jdk.git pull/29864/head:pull/29864
PR: https://git.openjdk.org/jdk/pull/29864
More information about the net-dev
mailing list