RFR: 8378398: Modernize test/jdk/java/net/URLClassLoader/HttpTest.java [v5]
Daniel Fuchs
dfuchs at openjdk.org
Thu Feb 26 15:03:35 UTC 2026
On Tue, 24 Feb 2026 14:58:25 GMT, Eirik Bjørsnøs <eirbjo at openjdk.org> wrote:
>> Please review this PR which modernizes `test/jdk/java/net/URLClassLoader/HttpTest.java`, a test verifying HTTP requests made by a URLClassLoader with HTTP search paths.
>>
>> The test is updated to replace a custom `HttpServer` class with one using `com.sun.net.httpserver`. Instead of simply counting GET and HEAD requests, the test now captures each request's method and URI in a log, which allows more precise asserts on the expected request patterns.
>>
>> The test is updated to use JUnit 5.
>>
>> For good measure, some negative test methods are added, verifying expected HTTP requests when one of the HTTP paths returns a 404 response.
>>
>> Test-only enhancement, `noreg-self`
>
> Eirik Bjørsnøs has updated the pull request incrementally with one additional commit since the last revision:
>
> Add tests for URLClassLoader::getResource following a redirect and another test where the redirect location returns 404 Not Found.
LGTM. Thanks for the cleanup.
-------------
Marked as reviewed by dfuchs (Reviewer).
PR Review: https://git.openjdk.org/jdk/pull/29864#pullrequestreview-3861556856
More information about the net-dev
mailing list