Need reviewer for 6907760: (file) OVERFLOW event should cause pending events to be purged

[Christopher Hegarty -Sun Microsystems Ireland]

Alan,

This change looks like a good optimization.

One thing I noticed is that if there are multiple events after an 
OVERFLOW, then the OVERFLOW count get incremented. I don't think this is 
a problem, does the count even make sense in this situation? Just a 
observation.

I also noticed the nice use of Objects.equals. Is the file system API 
backported to 1.6? Will this require a patch to compile/run on 1.6? I 
think the use of Objects.equals simplifies the logic and I like it. Just 
another observation.

-Chris.

Alan Bateman wrote:
> This is a follow-up to the discussion on the handling of WatchService 
> overflow events that John Hendrikx brought up on this mailing list in 
> December. A suggestion to come from that discussion is that the 
> implementation can drop pending events when queuing an overflow event. 
> That will save the application from needlessly processing these events. 
> Similarly, there isn't any point queuing events while there is an 
> overflow event pending.  The webrev with the proposed changes is here:
>  http://cr.openjdk.java.net/~alanb/6907760/webrev.00/
> 
> Thanks,
> Alan.