Need reviewer for 6907760: (file) OVERFLOW event should cause pending events to be purged
Alan Bateman
Alan.Bateman at Sun.COM
Tue Jan 5 03:38:32 PST 2010
Christopher Hegarty -Sun Microsystems Ireland wrote:
> Alan,
>
> This change looks like a good optimization.
>
> One thing I noticed is that if there are multiple events after an
> OVERFLOW, then the OVERFLOW count get incremented. I don't think this
> is a problem, does the count even make sense in this situation? Just a
> observation.
Thanks for reviewing. The incrementing of the overflow count is
intentional but not necessary. For debugging purposes it may give a hint
that many events are being dropped.
>
> I also noticed the nice use of Objects.equals. Is the file system API
> backported to 1.6? Will this require a patch to compile/run on 1.6? I
> think the use of Objects.equals simplifies the logic and I like it.
> Just another observation.
It's not a goal to run with jdk6 or older releases (and can't of course,
without work, because it's a new API and also updates existing APIs).
There are other jdk7 dependencies too so I'm not worried about it.
-Alan.
More information about the nio-dev
mailing list