Review request for #7087549

[Alan Bateman]

On 09/12/2011 19:07, Brandon Passanisi wrote:
> Hello nio-dev.  I was wondering if somebody could please review the 
> proposed fix for bug #7087549 : (fs) FileSystemProvider.newInputStream 
> throws IllegalArgumentException when custom open options.  The 
> information pertaining to the webrev and a description of the changes 
> are below:
>
>     Bug URL: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7087549
>     Webrev: http://cr.openjdk.java.net/~alanb/7087549/webrev/
>     <http://cr.openjdk.java.net/%7Ealanb/7087549/webrev/>
>
Brandon - thanks for taking this one. One thing with the changes is that 
the options aren't being passed through to Files.newByteChannel and so 
are being lost. If you do pass them through then the null check isn't 
strictly required as it should be done by newByteChannel.

-Alan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20111209/3c146e01/attachment.html