Review request for #7087549

[Brandon Passanisi]

Hi Alan.  I believe I understand the intention now.  Are you suggesting 
the following:

 1. Change the last line of newInputStream (line 384 in the webrev
    version of FileSystemProvider.java) so that the options parameter is
    passed into the Files.newByteChannel() call, i.e.: return
    Channels.newInputStream(Files.newByteChannel(path, options));
 2. Since the null check is done by newByteChannel, remove the
    Objects.requireNonNull call.

If this is correct, I can create an updated webrev for review.

Thanks.

On 12/9/2011 11:30 AM, Alan Bateman wrote:
> On 09/12/2011 19:07, Brandon Passanisi wrote:
>> Hello nio-dev.  I was wondering if somebody could please review the 
>> proposed fix for bug #7087549 : (fs) 
>> FileSystemProvider.newInputStream throws IllegalArgumentException 
>> when custom open options.  The information pertaining to the webrev 
>> and a description of the changes are below:
>>
>>     Bug URL: http://bugs.sun.com/bugdatabase/view_bug.do?bug_id=7087549
>>     Webrev: http://cr.openjdk.java.net/~alanb/7087549/webrev/
>>     <http://cr.openjdk.java.net/%7Ealanb/7087549/webrev/>
>>
> Brandon - thanks for taking this one. One thing with the changes is 
> that the options aren't being passed through to Files.newByteChannel 
> and so are being lost. If you do pass them through then the null check 
> isn't strictly required as it should be done by newByteChannel.
>
> -Alan.

-- 
Oracle <http://www.oracle.com>
Brandon Passanisi | Principle Member of Technical Staff

Green Oracle <http://www.oracle.com/commitment> Oracle is committed to 
developing practices and products that help protect the environment
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20111209/abde494a/attachment.html 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: oracle_sig_logo.gif
Type: image/gif
Size: 658 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20111209/abde494a/oracle_sig_logo.gif 
-------------- next part --------------
A non-text attachment was scrubbed...
Name: green-for-email-sig_0.gif
Type: image/gif
Size: 356 bytes
Desc: not available
Url : http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20111209/abde494a/green-for-email-sig_0.gif