Review Request : JDK-8002306, (se) Selector.open fails if invoked with thread interrupt status set [win]

[Alan Bateman]

On 18/12/2012 19:32, Dan Xu wrote:
> :
>
> I have updated my fix at, 
> http://cr.openjdk.java.net/~dxu/8002306/webrev.01/ 
> <http://cr.openjdk.java.net/%7Edxu/8002306/webrev.01/>.
>
> It removes checks of null or isConnected, and also addresses a 
> potential race situation by using an uninterruptible thread to 
> establish the loopback connections, which is the last resort to solve 
> the connection failures. In addition, the test is also updated to test 
> the pipe directly. Please review the new changes. Thanks!
>
> -Dan
I think the approach is good but I'd prefer if we didn't  duplicate the 
code to establish the loopback connection. If you could put this into 
own class (that implements Runnable) then you could invoke it directly 
first, and if that is interrupted then the background thread can invoke 
it from its run method.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20121218/87f744b6/attachment.html