Review Request : JDK-8002306, (se) Selector.open fails if invoked with thread interrupt status set [win]

[Dan Xu]

Hi Alan,

Your suggestion makes the code much leaner. I have updated the fix at, 
http://cr.openjdk.java.net/~dxu/8002306/webrev.02/ 
<http://cr.openjdk.java.net/%7Edxu/8002306/webrev.02/>

Please help review it. Thanks!

-Dan


On 12/18/2012 01:17 PM, Alan Bateman wrote:
> On 18/12/2012 19:32, Dan Xu wrote:
>> :
>>
>> I have updated my fix at, 
>> http://cr.openjdk.java.net/~dxu/8002306/webrev.01/ 
>> <http://cr.openjdk.java.net/%7Edxu/8002306/webrev.01/>.
>>
>> It removes checks of null or isConnected, and also addresses a 
>> potential race situation by using an uninterruptible thread to 
>> establish the loopback connections, which is the last resort to solve 
>> the connection failures. In addition, the test is also updated to 
>> test the pipe directly. Please review the new changes. Thanks!
>>
>> -Dan
> I think the approach is good but I'd prefer if we didn't duplicate the 
> code to establish the loopback connection. If you could put this into 
> own class (that implements Runnable) then you could invoke it directly 
> first, and if that is interrupted then the background thread can 
> invoke it from its run method.
>
> -Alan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20121219/f9bae87b/attachment.html