7173515: (se) Selector.open fails with OOME on Solaris when unlimited file descriptors

Alan Bateman Alan.Bateman at oracle.com
Sat Jun 2 12:47:34 PDT 2012


On 02/06/2012 13:23, Sean Coffey wrote:
> Looks good Alan - I might create a local test binary and run some 
> tests also.
>
> In the release method - line 206, can you explain why you're setting a 
> bit there ?
>
> 206                 registered.set(fd);
>
> would it not be a clear ?
Yes it should, well spotted. I missed that because it doesn't actually 
matter if the bit is cleared or not after the key is canceled. I've 
re-generated the webrev and re-test before pushing the changes. Thanks 
for reviewing in such detail.

-Alan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20120602/79e3b0a0/attachment.html 


More information about the nio-dev mailing list