7173515: (se) Selector.open fails with OOME on Solaris when unlimited file descriptors

[Chris Hegarty]

On 02/06/12 20:47, Alan Bateman wrote:
> On 02/06/2012 13:23, Sean Coffey wrote:
>> Looks good Alan - I might create a local test binary and run some
>> tests also.
>>
>> In the release method - line 206, can you explain why you're setting a
>> bit there ?
>>
>> 206 registered.set(fd);
>>
>> would it not be a clear ?
> Yes it should, well spotted. I missed that because it doesn't actually
> matter if the bit is cleared or not after the key is canceled. I've
> re-generated the webrev and re-test before pushing the changes. Thanks
> for reviewing in such detail.

The changes look good.

Trivially, the map could be created lazily (i guess it won't be used in 
many cases), but not a big deal.

-Chris.

>
> -Alan