7169050: (se) Selector.select slow on Solaris due to insertion of POLLREMOVE and 0 events

Chris Hegarty chris.hegarty at oracle.com
Wed May 23 05:46:58 PDT 2012


These changes look great Alan.

One minor comment, the events are now stored as a byte. Is it ever 
possible to have an event that has a valid value that uses the upper 
order byte ( that is passed to the native short pollfd.events )? It must 
not be, just thought I'd ask.

-Chris.

On 23/05/2012 10:48, Alan Bateman wrote:
> On 19/05/2012 11:26, Alan Bateman wrote:
>> :
>>
>> The webrev with a patch to fix these issues is here:
>>
>> http://cr.openjdk.java.net/~alanb/7169050/webrev/
> I've refreshed the webrev with an update that it a bit more efficient.
> The changes are relatively simple and as per the original mail, have the
> net effect of not queuing a POLLREMOVE per update and also removing the
> file descriptor from /dev/poll when the interest ops are changed to 0.
>
> -Alan.


More information about the nio-dev mailing list