7169050: (se) Selector.select slow on Solaris due to insertion of POLLREMOVE and 0 events

Alan Bateman Alan.Bateman at oracle.com
Wed May 23 06:15:30 PDT 2012


On 23/05/2012 13:46, Chris Hegarty wrote:
> These changes look great Alan.
>
> One minor comment, the events are now stored as a byte. Is it ever 
> possible to have an event that has a valid value that uses the upper 
> order byte ( that is passed to the native short pollfd.events )? It 
> must not be, just thought I'd ask.
In theory it should be a short[] but that takes up too much memory when 
a fd limit of 64k or higher. A byte works for us because the values of 
POLLIN and POLLOUT fit without any shifting or mapping. So thanks for 
reviewing, this resolves a long standing performance issue.

-Alan.


More information about the nio-dev mailing list