request for review: 7184932: Remove the temporary Selector usage in the NIO socket adapters

Rob McKenna rob.mckenna at oracle.com
Wed Oct 3 18:45:49 PDT 2012


Cheers Alan,

Latest changes are at:

http://cr.openjdk.java.net/~robm/7184932/webrev.03/ 
<http://cr.openjdk.java.net/%7Erobm/7184932/webrev.03/>

     -Rob

On 17/08/12 10:00, Alan Bateman wrote:
> On 15/08/2012 22:09, Rob McKenna wrote:
>> Hi folks,
>>
>> Looking for a codereview of this change. Basically we're looking to 
>> avoid the use of temporary selectors in socket adapters. This should 
>> result in resource usage improvements for users who make extensive 
>> use of these adapters in multiple threads.
>>
>> http://cr.openjdk.java.net/~robm/7184932/webrev.02/ 
>> <http://cr.openjdk.java.net/%7Erobm/7184932/webrev.02/>
>>
>> Thanks,
>>
>>     -Rob
> One other thing, now that this is extended to DatagramSocketAdpator 
> and ServerSocketChannelAdaptor then it you should be able to remove 
> getTemporarySelector and friends from sun.nio.ch.Util as I don't think 
> they are used anywhere else.
>
> -Alan.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20121004/d7309050/attachment.html 


More information about the nio-dev mailing list