request for review: 7184932: Remove the temporary Selector usage in the NIO socket adapters

[David M. Lloyd]

I'm wondering if it's really a good idea to hold blockingLock and all 
those other locks while waiting in Net.poll()?

Rather than preventing anything from changing during blocking, maybe 
it's better to just interrupt the poller instead.

On 10/03/2012 08:45 PM, Rob McKenna wrote:
> Cheers Alan,
>
> Latest changes are at:
>
> http://cr.openjdk.java.net/~robm/7184932/webrev.03/
> <http://cr.openjdk.java.net/%7Erobm/7184932/webrev.03/>
>
>      -Rob
>
> On 17/08/12 10:00, Alan Bateman wrote:
>> On 15/08/2012 22:09, Rob McKenna wrote:
>>> Hi folks,
>>>
>>> Looking for a codereview of this change. Basically we're looking to
>>> avoid the use of temporary selectors in socket adapters. This should
>>> result in resource usage improvements for users who make extensive
>>> use of these adapters in multiple threads.
>>>
>>> http://cr.openjdk.java.net/~robm/7184932/webrev.02/
>>> <http://cr.openjdk.java.net/%7Erobm/7184932/webrev.02/>
>>>
>>> Thanks,
>>>
>>>     -Rob
>> One other thing, now that this is extended to DatagramSocketAdpator
>> and ServerSocketChannelAdaptor then it you should be able to remove
>> getTemporarySelector and friends from sun.nio.ch.Util as I don't think
>> they are used anywhere else.
>>
>> -Alan.
>


-- 
- DML