RFR for JDK-8027212: java/nio/channels/Selector/SelectAfterRead.java fails intermittently

Eric Wang yiming.wang at oracle.com
Tue Dec 10 00:46:28 PST 2013


Hi Alan,

Sorry for late, I just got the internal agreement of the fix, the new 
version is to use CyclicBarrier to solve unclosed socket issue and 
sync-up client and server. Please review.
http://cr.openjdk.java.net/~ewang/JDK-8027212/webrev.02/

Thanks,
Eric
On 2013/11/25 20:46, Alan Bateman wrote:
> On 25/11/2013 09:15, Eric Wang wrote:
>> Hi Alan & All,
>>
>> I finally finished the internal discussion about the fix. Please 
>> review the webrev below, I also make some cleanup jobs, so other 3 
>> tests which uses ByteServer are changed.
>> http://cr.openjdk.java.net/~ewang/JDK-8027212/webrev.00/ 
>> <http://cr.openjdk.java.net/%7Eewang/JDK-8027212/webrev.00/>
>>
> This looks much better (and more extensive that the original proposal).
>
> Two comments on ByteServer:
>
> 1. It looks like socket is no longer closed.
>
> 2. You have removed savedException but that would be useful for the 
> run method to set so that it can be re-thrown by the close method.
>
> -Alan.
>
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20131210/9e1c1579/attachment.html 


More information about the nio-dev mailing list