RFR for JDK-8027212: java/nio/channels/Selector/SelectAfterRead.java fails intermittently
Alan Bateman
Alan.Bateman at oracle.com
Wed Dec 11 08:16:00 PST 2013
On 10/12/2013 08:46, Eric Wang wrote:
> Hi Alan,
>
> Sorry for late, I just got the internal agreement of the fix, the new
> version is to use CyclicBarrier to solve unclosed socket issue and
> sync-up client and server. Please review.
> http://cr.openjdk.java.net/~ewang/JDK-8027212/webrev.02/
>
Thanks for working on this. One thing is that creating the ByteServer
with a CyclicBarrier looks a bit odd Also the savedException is a bit
odd too as I don't think it is ever set.
I think these tests could be a bit simpler by just observing that the
conditions for the issues don't require the ByteServer to be running in
another thread. What would you think about just changing ByteServer to
run synchronously? If so then something like this should do it:
http://cr.openjdk.java.net/~alanb/8027212/webrev/
-Alan.
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20131211/5411354f/attachment.html
More information about the nio-dev
mailing list