Review Request : JDK-8002306, (se) Selector.open fails if invoked with thread interrupt status set [win]

[Dan Xu]

On 01/07/2013 08:36 AM, Alan Bateman wrote:
> On 03/01/2013 17:31, Dan Xu wrote:
>> I have made changes to my previous fix, and the latest one can be 
>> reviewed at http://cr.openjdk.java.net/~dxu/8002306/webrev.03/. 
>> Please help review it. Thanks!
>>
>> -Dan
>>
> This looks much better, I think PipeImpl is okay now.
>
> On the test then the assert in the run() method will only be effective 
> when running with -ea. That's okay except that if it fails then 
> AssertionError will be thrown and I don't think it will cause the test 
> to fail.  The other thing about the test is that the main thread is 
> calling close to close the "last" Pipe instance. I don't think this is 
> needed, the Pipe can be local to tester and it can close the 
> source/sink always.
>
> Otherwise I think we are close to the finish line on this one, I'm 
> happy to push it for you.
>
> -Alan 

I was not aware that the assertion error could not cause the test to 
fail. Thanks for pointing out. I modified the test and uploaded it to 
http://cr.openjdk.java.net/~dxu/8002306/webrev.04/. Please help take a 
look. Thanks!

-Dan
-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20130107/82bf0d7e/attachment.html