Review Request : JDK-8002306, (se) Selector.open fails if invoked with thread interrupt status set [win]

Alan Bateman Alan.Bateman at oracle.com
Tue Jan 8 08:02:52 PST 2013


On 08/01/2013 07:15, Dan Xu wrote:
>
> I was not aware that the assertion error could not cause the test to 
> fail. Thanks for pointing out. I modified the test and uploaded it to 
> http://cr.openjdk.java.net/~dxu/8002306/webrev.04/. Please help take a 
> look. Thanks!
Thanks, this looks much better now.

One small improvement for the test would be not to throw an IOException 
when the interrupt status is detected to be reset but rather just save 
it ("ie" could be an Exception). If you agree then I can make that 
(tiny) change before I push it for you later today.

-Alan

-------------- next part --------------
An HTML attachment was scrubbed...
URL: http://mail.openjdk.java.net/pipermail/nio-dev/attachments/20130108/2007976b/attachment.html 


More information about the nio-dev mailing list