Review Request : JDK-8002306, (se) Selector.open fails if invoked with thread interrupt status set [win]

Remi Forax forax at univ-mlv.fr
Tue Jan 8 08:10:51 PST 2013


On 01/08/2013 05:02 PM, Alan Bateman wrote:
> On 08/01/2013 07:15, Dan Xu wrote:
>>
>> I was not aware that the assertion error could not cause the test to 
>> fail. Thanks for pointing out. I modified the test and uploaded it to 
>> http://cr.openjdk.java.net/~dxu/8002306/webrev.04/. Please help take 
>> a look. Thanks!
> Thanks, this looks much better now.
>
> One small improvement for the test would be not to throw an 
> IOException when the interrupt status is detected to be reset but 
> rather just save it ("ie" could be an Exception). If you agree then I 
> can make that (tiny) change before I push it for you later today.
>
> -Alan
>

I think ioe should be volatile ?

Rémi



More information about the nio-dev mailing list